header.php error?

Photo, amazing way to showcase your architecture, photography or artistic projects | Support forum.
GK User
Fri Feb 19, 2016 12:07 pm
Hi,
while I'm customizing your source code I found what I think is an error. But I'm not an expert. Anyway:
line 72 73 of header.php
a </div> tag is missed or is out of the endif.
Could you please check this and, if there is an error, give me the right solution.
Thanks
User avatar
Junior Boarder

Joshua M
Mon Feb 22, 2016 1:35 pm
Hi,

I've checked my installation and can't see any problem. Please notice that there may be unclosed div in header.php file, but it's closed i.e. in the footer.php so everything is fine.
User avatar
Moderator

GK User
Tue Feb 23, 2016 12:27 pm
Thanks, I understand.
Anyway I realized I provided wrong line numbers. The corrects lines are from 28 to 44 header.php just for your information.
There is an if-else: in the else branch it opens 2 divs tags but close only one so it's strange to me.
<?php if .... ?>
<div class="gk-logo-.......">
..................
</div>
<?php else : ?>
<div class="gk-logo-............">
<div class="s..........">
.................................
</div>
<?php endif; ?>
</div>

But you are right, all works fine.
I'm just curious.
Sorry if i bother you again.
User avatar
Junior Boarder

Joshua M
Wed Feb 24, 2016 11:19 am
Hi,
I've checked it again and you're right - in the case when the top logo is not defined (the esle state) the second closing div should be placed before
Code: Select all
<?php endif; ?>

from line 43.

Thanks for your feedback, we'll fix it with the next theme update.
User avatar
Moderator


cron
Remember me
Register New Account
If you are old Gavick user, click HERE for steps to retrieve your account.
GavickPro website uses cookies. By continuing to use this website, you are giving consent to cookies being used. More details…×